bugfix: fail-on-request shouldn't fail if violation is excluded #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocastrodev
approved these changes
Sep 4, 2025
pboos
deleted the
bugfix/fail-on-request-shouldnt-fail-for-excluded-violations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves violations to be excluded earlier inside the
OpenApiRequestValidatorinstead of only in the violation handler.Fixes the following problem (but also others):
Steps to reproduce
openapi.validation.should-fail-on-request-violation=trueShould
Return 404
Actual
Returns 500 (because internally it has a violation that there is no spec for given path)