Merged
Conversation
maxheld
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
Pull Request Overview
Introduces comprehensive E2E tests for the spmgraph command-line tool that validate core functionality by running actual processes. The PR adds a dedicated test plan configuration, fixture package for testing, and comprehensive test coverage for all major commands.
Key changes:
- Adds E2E test suite that runs spmgraph commands via Process to test real-world usage
- Creates fixture package structure with targets and dependencies for testing
- Implements test plan configuration with Address Sanitizer enabled for graphviz compatibility
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spmgraph.xctestplan | Test plan configuration with environment variables and command-line arguments for E2E testing |
| Tests/SPMGraphExecutableTests/SPMGraphExecutableE2ETests.swift | Comprehensive E2E test suite covering all major spmgraph commands |
| Tests/Fixtures/Package/* | Test fixture package with targets, dependencies, and test files |
| Sources/SPMGraphVisualize/SPMGraphVisualize.swift | Updates to support AbsolutePath for output file handling |
| Sources/Core/Extensions/ProcessInfo+Core.swift | Helper extension to detect test environment |
| Package.swift | Adds SPMGraphExecutableTests target |
| .github/workflows/pull-request.yml | Updates CI to use xcodebuild with test execution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce E2E tests that run spmgraph commands via Process.
TODO