Skip to content

Experimental UI Tests flag && improvements#14

Merged
marinofelipe merged 3 commits intomainfrom
improvements
Sep 23, 2025
Merged

Experimental UI Tests flag && improvements#14
marinofelipe merged 3 commits intomainfrom
improvements

Conversation

@marinofelipe
Copy link
Contributor

  • Adds missing experimental flag for mapping the UI Test Targets to run
  • Updates the test action with such a flag and changes inputs from snake case to kebab case

@marinofelipe marinofelipe self-assigned this Sep 23, 2025
@marinofelipe marinofelipe requested a review from a team as a code owner September 23, 2025 22:42
Copilot AI review requested due to automatic review settings September 23, 2025 22:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds experimental support for UI test targets in the SPM graph testing functionality. The main purpose is to allow the tool to optionally include UI test targets when determining which tests to run based on affected dependencies.

  • Adds a new experimental flag experimentalUITestTargets to enable UI test target mapping
  • Updates the GitHub Action to use kebab-case input parameters instead of snake_case
  • Implements logic to read UI test dependencies from a JSON file and include them in test selection

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

File Description
Sources/SPMGraphTests/SPMGraphTests.swift Adds experimental UI test targets support with JSON dependency mapping
Sources/SPMGraphExecutable/Subcommands/Tests.swift Adds command-line flag for experimental UI test feature
.github/actions/tests/action.yml Updates input parameter names to kebab-case and adds UI test flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

print(">>> file path \(uiTestsDependenciesFilePath)")

if localFileSystem.exists(uiTestsDependenciesFilePath) {
print(">>> file exists")
Copy link

Copilot AI Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug print statements should be removed or replaced with proper logging that respects the verbose flag. These hardcoded print statements will always output regardless of the verbose setting.

Suggested change
print(">>> file exists")
if input.verbose {
try system.echo(">>> file exists")
}

Copilot uses AI. Check for mistakes.
@marinofelipe marinofelipe merged commit 97ab31a into main Sep 23, 2025
5 checks passed
@marinofelipe marinofelipe deleted the improvements branch September 23, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants