Experimental UI Tests flag && improvements#14
Merged
marinofelipe merged 3 commits intomainfrom Sep 23, 2025
Merged
Conversation
Contributor
marinofelipe
commented
Sep 23, 2025
- Adds missing experimental flag for mapping the UI Test Targets to run
- Updates the test action with such a flag and changes inputs from snake case to kebab case
There was a problem hiding this comment.
Pull Request Overview
This PR adds experimental support for UI test targets in the SPM graph testing functionality. The main purpose is to allow the tool to optionally include UI test targets when determining which tests to run based on affected dependencies.
- Adds a new experimental flag
experimentalUITestTargetsto enable UI test target mapping - Updates the GitHub Action to use kebab-case input parameters instead of snake_case
- Implements logic to read UI test dependencies from a JSON file and include them in test selection
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Sources/SPMGraphTests/SPMGraphTests.swift | Adds experimental UI test targets support with JSON dependency mapping |
| Sources/SPMGraphExecutable/Subcommands/Tests.swift | Adds command-line flag for experimental UI test feature |
| .github/actions/tests/action.yml | Updates input parameter names to kebab-case and adds UI test flag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| print(">>> file path \(uiTestsDependenciesFilePath)") | ||
|
|
||
| if localFileSystem.exists(uiTestsDependenciesFilePath) { | ||
| print(">>> file exists") |
There was a problem hiding this comment.
Debug print statements should be removed or replaced with proper logging that respects the verbose flag. These hardcoded print statements will always output regardless of the verbose setting.
Suggested change
| print(">>> file exists") | |
| if input.verbose { | |
| try system.echo(">>> file exists") | |
| } |
3f24a01 to
ac2f29f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.