Skip to content

Update conditions for summary and PR comments #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marinofelipe merged 2 commits into from
Oct 15, 2025
Merged

Update conditions for summary and PR comments #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6ac3ca
Update conditions for summary and PR comments
marinofelipe Oct 15, 2025
57b336b
Update action.yml
marinofelipe Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/lint/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ runs:
shell: /bin/bash -e {0}

- name: Write to workflow job summary
if: ${{ inputs.adds-to-summary == 'true' }}
if: ${{ always() && inputs.adds-to-summary == 'true' }}
run: |
lint_summary=$'# spmgraph lint\n## Results\n'
echo "$lint_summary" >> $GITHUB_STEP_SUMMARY
Expand All @@ -68,15 +68,15 @@ runs:
shell: /bin/bash -e {0}

- name: Report warnings as a PR comment
if: ${{ inputs.adds-pr-comment == 'true' && steps.lint-dependency-graph.outputs.lint-failed == 'true' }}
if: ${{ always() && inputs.adds-pr-comment == 'true' && steps.lint-dependency-graph.outputs.lint-failed == 'true' }}
continue-on-error: true # Do not fail the workflow if the comment fails or if not a PR
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
with:
file-path: /Users/administrator/runner/_work/iOS/iOS/lint_output.txt
comment-tag: lint-report # the same across runs, which updates the comment from previous runs

- name: Report lint passed as a PR comment
if: ${{ inputs.adds-pr-comment == 'true' && steps.lint-dependency-graph.outputs.lint-failed == 'false' }}
if: ${{ always() && inputs.adds-pr-comment == 'true' && steps.lint-dependency-graph.outputs.lint-failed == 'false' }}
continue-on-error: true # Do not fail the workflow if the comment fails or if not a PR
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
with:
Expand Down