Skip to content

7 make noise dtype passable#9

Merged
gfdb merged 3 commits intomainfrom
7-make-noise_dtype-passable
Feb 8, 2026
Merged

7 make noise dtype passable#9
gfdb merged 3 commits intomainfrom
7-make-noise_dtype-passable

Conversation

@gfdb
Copy link
Owner

@gfdb gfdb commented Feb 6, 2026

In this PR we do a few things.

  1. We made noise_dtype passable directly from the wav2aug object. This will allow the user to specify how they would like to store the pointsource noises in memory e.g. fp32, fp16, etc...
  2. We removed the option to load noise synchronously one file at a time using dataloaders cause it was super slow. If there are people who really don't want to consume ~1 GB (or less if using < fp32 for the pointsource noises, I'll add a dataloader option with support for multiple workers when those people complain.
  3. Updated/added tests

closes #7

@gfdb gfdb linked an issue Feb 6, 2026 that may be closed by this pull request
@gfdb gfdb merged commit 0641f2e into main Feb 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make noise_dtype passable

1 participant