Conversation
cwfitzgerald
left a comment
There was a problem hiding this comment.
Interesting, what errors do you get on msvc?
In addition to adding it to the Readme, we should explicitly check the msvc version in the build script (using https://docs.rs/cc/latest/cc/windows_registry/fn.find_vs_version.html) and raise an explicit error.
README.md
Outdated
| In order to keep a small dependency closure, this crate does not depend on `image`, | ||
| but interop is simple. | ||
|
|
||
| ## Requirement |
There was a problem hiding this comment.
Let's just make a top level windows section.
look like MCVC 2019 is not enough for this project.
|
I didn't save the error sorry, I think he didn't like nv-flip-rs/nv-flip-sys/src/bindings.cpp Line 70 in d532489 |
|
here I uninstall it just for you MSVC 2019 16.2.5: |
|
It's look like MSVC 2019 16.11.30 is enough to compile nv-flip-sys |
|
Cool, thank you! |
|
(This still needs a proper error in the build script) |
look like MCVC 2019 is not enough for this project.