Skip to content

Conversation

MarijnS95
Copy link
Collaborator

@MarijnS95 MarijnS95 commented Jun 20, 2025

@kvark
Copy link
Member

kvark commented Sep 24, 2025

LGTM, but who is generally reviewing rspirv these days?

@MarijnS95 MarijnS95 changed the title Regenerate on sdk-1.4.313.0 Regenerate on sdk-1.4.321.0 Sep 24, 2025
@MarijnS95
Copy link
Collaborator Author

@kvark I don't know unfortunately 😅 - I've mostly been performing upgrades and fixing random user reports while I didn't really have a use for this crate myself, but it still seems gfx-rs is using it in naga? @msiglreith used to be reviewing my PRs in the past at least :)

@MarijnS95
Copy link
Collaborator Author

Looking at the diff myself, I've yet to add some new OpTypes to the grammar so that we don't end up with an error like #266 later, will do so soon.

@MarijnS95
Copy link
Collaborator Author

It always surprised me that we had to manually add these (and have a lot of bugs like #266 as a result), even though they can be very trivially generated: #269

| spirv::Op::SpecConstantOp
| spirv::Op::ConstantCompositeContinuedINTEL
| spirv::Op::SpecConstantCompositeContinuedINTEL
| spirv::Op::GraphConstantARM
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following #269 it turns out OpGraphConstantARM isn't actually a constant, but from the Graph class - it might still define a constant though? Needs to be tested, because this will otherwise be removed from the new is_constant(self) function.

@MarijnS95 MarijnS95 changed the title Regenerate on sdk-1.4.321.0 Regenerate on sdk-1.4.328.1 Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants