-
Notifications
You must be signed in to change notification settings - Fork 64
Regenerate on sdk-1.4.328.1
#262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
a864a2a
to
b1f0069
Compare
LGTM, but who is generally reviewing rspirv these days? |
@kvark I don't know unfortunately 😅 - I've mostly been performing upgrades and fixing random user reports while I didn't really have a use for this crate myself, but it still seems |
Looking at the diff myself, I've yet to add some new |
b1f0069
to
e305913
Compare
rspirv/grammar/reflect.rs
Outdated
| spirv::Op::SpecConstantOp | ||
| spirv::Op::ConstantCompositeContinuedINTEL | ||
| spirv::Op::SpecConstantCompositeContinuedINTEL | ||
| spirv::Op::GraphConstantARM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following #269 it turns out OpGraphConstantARM
isn't actually a constant, but from the Graph
class - it might still define a constant though? Needs to be tested, because this will otherwise be removed from the new is_constant(self)
function.
https://github.com/KhronosGroup/SPIRV-Headers/releases/tag/vulkan-sdk-1.4.321.0