Skip to content

OLD: Update Rust crate bincode to v2 #7615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

OLD: Update Rust crate bincode to v2 #7615

wants to merge 1 commit into from

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Apr 23, 2025

This PR contains the following updates:

Package Type Update Change
bincode workspace.dependencies major 1 -> 2

Release Notes

bincode-org/bincode (bincode)

v2.0.1

Compare Source

What's Changed

New Contributors

Full Changelog: bincode-org/bincode@v2.0.0...v2.0.1

v2.0.0

Compare Source

Stable! Finally! After 4 years in development! Many changes have made it in since rc.3, including (unfortunately) some last minute breaking changes. But documentation has been cleaned up to a point where we finally feel comfortable committing to things as they are.

If you haven't been following along with the 2.0 changes here is a brief overview

  • Completely rewritten API decoupled from serde
  • no_std support
  • Official format specification
  • Default configuration changes
  • Increase MSRV to 1.85.0

What's Changed since 1.3.1

New Contributors

Full Changelog: bincode-org/bincode@v1.3.1...v2.0.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner April 23, 2025 21:07
@renovate
Copy link
Contributor Author

renovate bot commented Apr 23, 2025

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path Cargo.toml --package [email protected] --precise 2.0.1
    Updating crates.io index
error: failed to select a version for the requirement `bincode = "^1"`
candidate versions found which didn't match: 2.0.1
location searched: crates.io index
required by package `deno_core v0.336.0`
    ... which satisfies dependency `deno_core = "^0.336.0"` (locked to 0.336.0) of package `cts_runner v25.0.0 (/tmp/renovate/repos/github/gfx-rs/wgpu/cts_runner)`

@cwfitzgerald
Copy link
Member

cwfitzgerald commented Apr 23, 2025

Bincode seems to require rustc 1.85. It is only used by the benchmarks and naga-cli, so can go in, but would require bumping our repo msrv. @LegNeato is #7409 still a problem for you?

@LegNeato
Copy link
Contributor

LegNeato commented Apr 23, 2025

It is but we're working hard to port forward. It will be a couple more weeks at this pace...we're doing gnarly untyped memory stuff. If you could hold off that would be great! If not I understand.

@cwfitzgerald
Copy link
Member

cwfitzgerald commented Apr 23, 2025 •
edited
Loading

Oh a couple weeks that's great! When I saw "patches on rustc" I was thinking months to years lol

No rush at all! What issue should I follow until we're unblocked? Rust-GPU/rust-gpu#182?

Closing this as blocked.

@renovate
Copy link
Contributor Author

renovate bot commented Apr 23, 2025

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 2.x releases. But if you manually upgrade to 2.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/bincode-2.x branch April 23, 2025 21:46
@LegNeato
Copy link
Contributor

LegNeato commented Apr 24, 2025 •
edited
Loading

Yep, Rust-GPU/rust-gpu#182

@cwfitzgerald
Copy link
Member

cwfitzgerald commented Apr 24, 2025

Thanks!

@cwfitzgerald cwfitzgerald mentioned this pull request Apr 25, 2025
Closed
1 task
@LegNeato
Copy link
Contributor

LegNeato commented Jul 10, 2025

@cwfitzgerald even though that issue isn't closed, rust-gpu updated to a newer rust version in Rust-GPU/rust-gpu#320

@cwfitzgerald
Copy link
Member

cwfitzgerald commented Jul 10, 2025

Amazing stuff! I'll also put a backlink to the current rust-gpu rustc version so when we bump versions we don't cause issues :)

@cwfitzgerald cwfitzgerald changed the title Update Rust crate bincode to v2 OLD: Update Rust crate bincode to v2 Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cwfitzgerald @LegNeato