[hal] allow for PreMultiplied alpha mode on the web
#7993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grovesNL I'm going away on vacation, could you take a look at this if you have some time? |
cwfitzgerald
requested changes
Aug 27, 2025
Comment on lines
+1235
to
+1238
| composite_alpha_modes: vec![ | ||
| wgt::CompositeAlphaMode::Opaque, | ||
| wgt::CompositeAlphaMode::PreMultiplied, | ||
| ], //TODO |
There was a problem hiding this comment.
I don't think this is right - without telling this to the runtime at all we can't know if these modes are actually supported. I'm not sure how this works with the various platforms, but I don't think we can just change it.
There was a problem hiding this comment.
It look like premultipliedAlpha is set to true by default https://registry.khronos.org/webgl/specs/latest/1.0/#5.2 and we do not seem to change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CompositeAlphaMode::PreMultipliedwas missing in WebGPU and GLES supportedalpha_modesTesting
Manually for both Android (GLES) and the Web (WebGL and WebGPU)
Checklist
cargo fmt.Runtaplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.If this contains user-facing changes, add aCHANGELOG.mdentry.