fix STATUS_HEAP_CORRUPTION crash in create_sampler

[atlv24]

Connections
Fixes bevyengine/bevy#20379

Description
The unsafe in hal vk create_sampler is unsound.

Testing
Reproduction case:

use std::thread;
struct Example {}
impl crate::framework::Example for Example {
    fn init(
        _config: &wgpu::SurfaceConfiguration,
        _adapter: &wgpu::Adapter,
        device: &wgpu::Device,
        _queue: &wgpu::Queue,
    ) -> Self {
        thread::scope(move |s| {
            for i in 0..100 {
                s.spawn(|| {
                    for i in 0..100000 {
                        let _ = device.create_sampler(&wgpu::SamplerDescriptor {
                            label: Some("My Label"),
                            ..Default::default()
                        });
                    }
                });
            }
        });
        Self {}
    }
    fn resize(
        &mut self,
        _config: &wgpu::SurfaceConfiguration,
        _device: &wgpu::Device,
        _queue: &wgpu::Queue,
    ) {
    }
    fn update(&mut self, _event: winit::event::WindowEvent) {}
    fn render(&mut self, _view: &wgpu::TextureView, _device: &wgpu::Device, _queue: &wgpu::Queue) {}
}

Squash or Rebase?

squash

Checklist

• Run cargo fmt.
• Run taplo format.
• Run cargo clippy --tests. If applicable, add:
  • --target wasm32-unknown-unknown
• Run cargo xtask test to run tests.
• If this contains user-facing changes, add a CHANGELOG.md entry.

[ErichDonGubler]

LGTM, minus a nit I'm going to fix right now.

[atlv24]

One more note is set_object_name currently has a safety comment that says "must be valid to call set_object_name" and that's like... very undescriptive? It would be good to elaborate on when its valid to call, like no concurrent access (and any other requirements)

[ErichDonGubler]

@atlv24: Just filed #8055.