[deno] Enable additional vertex formats #8095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
andyleiserson
force-pushed
the
deno-vertex-formats
branch
3 times, most recently
from
649ade0 to
0c13dd6
Compare
ErichDonGubler
approved these changes
Aug 19, 2025
There was a problem hiding this comment.
note: These are likely missing for the same reason that Firefox was missing them (see bug 1933317, gpuweb/gpuweb#4951, #6614); they're recent resurrections in the spec.
crowlKats
approved these changes
Aug 20, 2025
andyleiserson
force-pushed
the
deno-vertex-formats
branch
from
0c13dd6 to
32166fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on top of #8085. The two changes don't directly relate, but are both useful in the context of other changes I am working on.
Enable additional vertex formats in deno. There wasn't any note about why they aren't enabled, but they were only added to wgpu relatively recently, so I'm assuming there wasn't any reason beyond that for deno to exclude them.
Testing
Tested this change with the
webgpu:api,operation,vertex_state,correctness:setVertexBuffer_offset_and_attribute_offsetCTS test, but I am still working on other things that may affect the stability of this test in CI, so I have not added it to the regression.Squash or Rebase? Squash (after merging #8085)
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.