Use pointers instead of IDs for tracing #8289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use it to deduplicate some `Foo` / `ArcFoo` / `TraceFoo` definitions.
This updates pass operations. The trace player is temporarily broken.
This updates non-pass command encoder operations and device operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #8288.
This resolves the duplicate storage of
IdandArcversions of commands when tracing that was introduced by encode-on-finish. It now stores theArcversion only, and uses the pointers from theArcs as object IDs when tracing. It also overhauls the trace player to play back traces in this format.This fixes tracing of compute and render passes when encoded using the standard APIs. Tracing of render bundles is still broken.
Testing
TBD. Existing player tests, manual tests, and it would be nice to have an automated test of recording a trace but I don't think we do right now.
Squash or Rebase? TBD, probably rebase.
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.