(Naga) Implement OpSpecConstantOp for the SPIR-V frontend #8308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement OpSpecConstantOp for the SPIR-V frontend.
This implementation solves all my problems that I had with SLANGC output.
But I couldn't implement all operations. The following are missing:
It is possible to write GLSL that is valid SPIR-V but not valid SPIR-V for Naga. For example the amount of shifts can be defined with both signed and unsigned values in GLSL, but Naga expects, when validating the shader, an unsigned value. Sometimes the GLSL compiler also produces weird SPIR-V. For example:
will result in the folling ASM:
Which will not be evaluated successfully, since we again mix signed and unsigned constants.
But I think it's still mergeable, since we implement a pretty big subset of OpSpecConstantOp.
Testing
I added two snapshot tests. One based on GLSL code and one in pure SPVASM, that tests more complex chained OpSpecConstantOps.
Squash or Rebase?
Rebase
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:cargo xtask test
to run tests.CHANGELOG.md
entry.