bug fixes - TIME mismatch and labels in individual plots#406
Open
ggPMXdevelopment wants to merge 9 commits intomasterfrom
Open
bug fixes - TIME mismatch and labels in individual plots#406ggPMXdevelopment wants to merge 9 commits intomasterfrom
ggPMXdevelopment wants to merge 9 commits intomasterfrom
Conversation
…ions as in the input dataset.
ggPMXdevelopment
changed the title
mattfidler
reviewed
Sep 3, 2025
R/plot-individual.R
Outdated
| # Rounding because "predictions" data are rounded: | ||
| point$data$isobserv <- | ||
| ifelse(round(point$data$TIME) <= point$data$maxValue, "accepted", "ignored") | ||
| ifelse(round(point$data$TIME) <= point$data$maxValue, " observed", "censored") |
R/pmx-reader.R
Outdated
| } | ||
| ds <- merge(ds, resi, by = c("ID", "TIME")) | ||
| #Workaround for mlx18 prec | ||
| ds <- merge(ds %>% mutate(TIME = round(TIME, 4)), resi %>% mutate(TIME = round(TIME, 4)), by = c("ID", "TIME")) |
mattfidler
approved these changes
Sep 5, 2025
| # ggPMX 1.3.2 | ||
| * Fixed bug resulting in missing points upon mergin observations and predictions | ||
|
|
||
| * Changed labels in individual plots form accepted/ignored to observed/censored (Should be removed in the future) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazy fix for mismatch in TIME in observed and predicted data due to rounding #404
Fix accepted/ignored labels to observed/censored in individual plots #403
Close #371 Close #403 Close #404