-
Couldn't load subscription status.
- Fork 1.4k
gguf.md: add sharding to naming convention #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gguf.md: add sharding to naming convention #826
Conversation
68fcf99 to
5f75cab
Compare
5f75cab to
c0f25bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
…expert count [no ci]
1fd0058 to
0b3cbe4
Compare
|
Minor commit to address Justine's observation that
So recommended that the model, version and expert count be derived from gguf metadata. This consistency should hopefully reduce surprises when creating upload scripts by making the filename generation a bit more repeatable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it!
|
@ggerganov ready to merge |
1ef8674 to
25d5656
Compare
|
Still ready for review @ggerganov , just added a regex example and tighten up the description. |
|
@mishig25 it's now merged in, so you can use it now :) |
|
@mofosyne Awesome! |
As per #822 (review) suggestion, adding support for sharding in naming convention.
Was a bit worried about if
-of-is going to be annoying to parse, but I think it's not too much to ask programmers to check ifXXXXX-of-XXXXXexist first and delete that before processing the rest from right to left by splitting by-. The requirement for 5 digits and-of-is pretty distinctive anyway.@ggerganov this is a PR to add this idea on behalf of @mishig25 and based on checking hf it appears to be a common enough convention already e.g. vicuna.gguf