Skip to content

Conversation

@mofosyne
Copy link
Contributor

ggml-org/llama.cpp#7499 was merged in, thus this PR is to sync to this new form

<BaseName><SizeLabel><FineTune><Version><Encoding><Type><Shard>.gguf

I also updated the validation regexp you can use

^(?<BaseName>[A-Za-z0-9\s]*(?:(?:-(?:(?:[A-Za-z\s][A-Za-z0-9\s]*)|(?:[0-9\s]*)))*))-(?:(?P<SizeLabel>(?:\d+x)?(?:\d+\.)?\d+[A-Za-z](?:-[A-Za-z]+(\d+\.)?\d+[A-Za-z]+)?)(?:-(?P<FineTune>[A-Za-z0-9\s-]+))?)?-(?:(?P<Version>v\d+(?:\.\d+)*))(?:-(?<Encoding>(?!LoRA|vocab)[\w_]+))?(?:-(?<Type>LoRA|vocab))?(?:-(?P<Shard>\d{5}-of-\d{5}))?\.gguf$

You can check how it works in https://regex101.com/r/7DgTVN/1

It is now updated to this form

`<BaseName><SizeLabel><FineTune><Version><Encoding><Type><Shard>.gguf`
@mofosyne
Copy link
Contributor Author

for vocab files... does a size label even make sense?

@ggerganov ggerganov merged commit f18a111 into ggml-org:master Jul 22, 2024
@mofosyne mofosyne deleted the namingconvention branch July 22, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants