ggml-opencl : fix padding in timestep embedding kernel

danbev · danbev · commit a1de8bd82757 · 2025-09-16T09:15:37.000+02:00
This commit fixes the zero padding for odd dimensions in
the timestep embedding kernel.
diff --git a/ggml/src/ggml-opencl/kernels/tsembd.cl b/ggml/src/ggml-opencl/kernels/tsembd.cl
@@ -26,8 +26,8 @@ kernel void kernel_timestep_embedding(
     local_half_dim = logical_dim / 2;
     local_embed_data_ptr = (global float *)((global char *)local_dst_output_base_ptr + local_i * dst_nb1_bytes);
 
-    if (logical_dim % 2 != 0 && local_j == ((logical_dim + 1) / 2)) {
-        local_embed_data_ptr[logical_dim] = 0.0f;
+    if (logical_dim % 2 != 0 && local_j == local_half_dim) {
+        local_embed_data_ptr[2 * local_half_dim] = 0.0f;
     }
 
     if (local_j >= local_half_dim) {

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,8 @@ kernel void kernel_timestep_embedding(`
`26`	`26`	`local_half_dim = logical_dim / 2;`
`27`	`27`	`local_embed_data_ptr = (global float )((global char )local_dst_output_base_ptr + local_i * dst_nb1_bytes);`
`28`	`28`
`29`		`- if (logical_dim % 2 != 0 && local_j == ((logical_dim + 1) / 2)) {`
`30`		`- local_embed_data_ptr[logical_dim] = 0.0f;`
	`29`	`+ if (logical_dim % 2 != 0 && local_j == local_half_dim) {`
	`30`	`+ local_embed_data_ptr[2 * local_half_dim] = 0.0f;`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`if (local_j >= local_half_dim) {`