Skip to content

Conversation

MollySophia
Copy link
Collaborator

  • Removed useless template matching for rwkv-world since there actually isn't a template to match, which may also cause issues for other models, as per the conversation in Add chat template for RWKV-World #9968.
  • Added a comment about the EOT token hack for current RWKV models.

Thanks to @ngxson

@github-actions github-actions bot added testing Everything test related python python script changes labels Oct 22, 2024
Co-authored-by: Xuan Son Nguyen <[email protected]>
@ngxson ngxson merged commit 11d4705 into ggml-org:master Oct 22, 2024
54 checks passed
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
* llama: remove useless template matching for rwkv-world

Signed-off-by: Molly Sophia <[email protected]>

* converter: Add comment about the hack for rwkv models

Signed-off-by: Molly Sophia <[email protected]>

* Update src/llama.cpp

Co-authored-by: Xuan Son Nguyen <[email protected]>

---------

Signed-off-by: Molly Sophia <[email protected]>
Co-authored-by: Xuan Son Nguyen <[email protected]>
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
* llama: remove useless template matching for rwkv-world

Signed-off-by: Molly Sophia <[email protected]>

* converter: Add comment about the hack for rwkv models

Signed-off-by: Molly Sophia <[email protected]>

* Update src/llama.cpp

Co-authored-by: Xuan Son Nguyen <[email protected]>

---------

Signed-off-by: Molly Sophia <[email protected]>
Co-authored-by: Xuan Son Nguyen <[email protected]>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
* llama: remove useless template matching for rwkv-world

Signed-off-by: Molly Sophia <[email protected]>

* converter: Add comment about the hack for rwkv models

Signed-off-by: Molly Sophia <[email protected]>

* Update src/llama.cpp

Co-authored-by: Xuan Son Nguyen <[email protected]>

---------

Signed-off-by: Molly Sophia <[email protected]>
Co-authored-by: Xuan Son Nguyen <[email protected]>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
* llama: remove useless template matching for rwkv-world

Signed-off-by: Molly Sophia <[email protected]>

* converter: Add comment about the hack for rwkv models

Signed-off-by: Molly Sophia <[email protected]>

* Update src/llama.cpp

Co-authored-by: Xuan Son Nguyen <[email protected]>

---------

Signed-off-by: Molly Sophia <[email protected]>
Co-authored-by: Xuan Son Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants