Skip to content

ggml : fix memory leaks when loading invalid gguf files #10094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 30, 2024
Merged

ggml : fix memory leaks when loading invalid gguf files #10094

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5bd963e
ggml : fix gguf string leak when reading kv pairs fails
slaren Oct 30, 2024
2923456
ggml : avoid crashing with GGML_ABORT when the KV has an invalid type
slaren Oct 30, 2024
f509f45
fix style
slaren Oct 30, 2024
9719dad
ggml : avoid crashing on failed memory allocations when loading a ggu…
slaren Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ggml/src/ggml.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22329,17 +22329,23 @@ struct gguf_context * gguf_init_from_file(const char * fname, struct gguf_init_p
}
} break;
case GGUF_TYPE_ARRAY:
default: GGML_ABORT("invalid type");
default:
fprintf(stderr, "%s: invalid array type %d\n", __func__, kv->value.arr.type);
ok = false;
break;
}
} break;
default: GGML_ABORT("invalid type");
default:
fprintf(stderr, "%s: invalid type %d\n", __func__, kv->type);
ok = false;
break;
}

ctx->header.n_kv++;

if (!ok) {
break;
}

ctx->header.n_kv++;
}

if (!ok) {
Expand Down
Loading