Skip to content

ggml : check tensor name lengths in gguf files #10100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

ggml : check tensor name lengths in gguf files #10100

merged 1 commit into from
Oct 31, 2024

Conversation

slaren
Copy link
Member

@slaren slaren commented Oct 30, 2024

  • Do not allow tensors with names that exceed GGML_MAX_NAME
  • Return an error when tensors have invalid attributes instead of asserting

@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Oct 30, 2024
@slaren slaren merged commit dea5e86 into master Oct 31, 2024
54 checks passed
@slaren slaren deleted the sl/fix-gguf-tensor-name-len branch October 31, 2024 10:41
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
@slaren @arthw
ggml : check tensor name lengths in gguf files (ggml-org#10100)
d380aee
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
@slaren @arthw
ggml : check tensor name lengths in gguf files (ggml-org#10100)
2f89a20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slaren @ggerganov