main: add test-cli + ensure completion goes to stdout even w/ --log-disable
#10102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
slaren
reviewed
Oct 30, 2024
tests/test-cli.cpp
Outdated
Comment on lines
66
to
68
| auto p = run(cli_bin + " -hfr ggml-org/models -hff tinyllamas/stories260K.gguf --prompt hello --seed 42 -ngl 0 -n 10"); | ||
| assert_equals(" hello Joe and Joe we", p.out); | ||
| assert_contains("system_info:", p.err); |
There was a problem hiding this comment.
Default sampling settings can change in the future, using greedy sampling here may be more reliable.
ggerganov
reviewed
Oct 31, 2024
Comment on lines
719
to
+721
| // Console/Stream Output | ||
| LOG("%s", token_str.c_str()); | ||
| fprintf(stdout, "%s", token_str.c_str()); | ||
| fflush(stdout); |
There was a problem hiding this comment.
Mixing printf and common/log is not recommended because they run on 2 different threads and the output can get out of order. Maybe try using LOGV(-1, ...); and then instead of --log-disable use --log-verbosity -1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing to restore the plain, stdout behaviour of
llama-cli.Introduced a mini test that checks that
llama-cli -p hello --log-disable/llama-cli -p hello 2>/dev/nulloutputs just the (prompt and) completion text.(currently
--log-disabledisables... everything)