-
Notifications
You must be signed in to change notification settings - Fork 13.5k
server: (web UI) Add samplers sequence customization #10255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0945da8
Samplers sequence: simplified and input field.
MaggotHATE a2112f0
Removed unused function
MaggotHATE a1ee42d
Merge branch 'ggerganov:master' into server-chat-templates
MaggotHATE 9d08ae3
Merge branch 'ggerganov:master' into server-chat-templates
MaggotHATE 5718cbb
Merge branch 'ggerganov:master' into server-chat-templates
MaggotHATE 7a24341
Merge branch 'ggerganov:master' into server-chat-templates
MaggotHATE 7f9e2f1
Modify and use `settings-modal-short-input`
MaggotHATE 3b837fe
rename "name" --> "label"
ngxson 04a0711
Merge branch 'ggerganov:master' into server-chat-templates
MaggotHATE File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be inside "Other sampler settings"
The "advanced" is mostly for non-sampler stuff I think, like pinning slot number or stop sequence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw if you merge with latest upstream master branch, you can re-use the
settings-modal-short-inputcomponentUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it works! However, the name is automatically set to
samplers, which is not very descriptive.Should I modify
settings-modal-short-inputto have a separate value for name? UPD: seems to work just fine. It would also allow setting prettier names for sampler parameters later.