Skip to content

server : fix incorrect res in validate_model_chat_template #10272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024
Merged

server : fix incorrect res in validate_model_chat_template #10272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71c2c7f
server : fix validate_model_chat_template
jhen0409 Nov 13, 2024
0b069a4
server : fix chat res
jhen0409 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions examples/server/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,11 +655,16 @@ struct server_context {
}

bool validate_model_chat_template() const {
llama_chat_message chat[] = {{"user", "test"}};

const int res = llama_chat_apply_template(model, nullptr, chat, 1, true, nullptr, 0);

return res > 0;
std::vector<char> model_template(2048, 0); // longest known template is about 1200 bytes
std::string template_key = "tokenizer.chat_template";
int32_t res = llama_model_meta_val_str(model, template_key.c_str(), model_template.data(), model_template.size());
if (res >= 0) {
llama_chat_message chat[] = {{"user", "test"}};
std::string tmpl = std::string(model_template.data(), model_template.size());
int32_t chat_res = llama_chat_apply_template(model, tmpl.c_str(), chat, 1, true, nullptr, 0);
return chat_res > 0;
}
return false;
}

void init() {
Expand Down
Loading