Skip to content

vulkan: the index in ggml_vk_host_free could be uninitialized #10331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

vulkan: the index in ggml_vk_host_free could be uninitialized #10331

wants to merge 5 commits into from

Conversation

@FirstTimeEZ
Copy link
Contributor

@FirstTimeEZ FirstTimeEZ commented Nov 16, 2024 •
edited
Loading

@0cc4m
Copy link
Collaborator

0cc4m commented Nov 17, 2024

It could be, but in that case buf == nullptr and index is never used, so it doesn't need to be initialized.

@FirstTimeEZ FirstTimeEZ deleted the vulkan-initialize-value branch November 17, 2024 21:07
@FirstTimeEZ FirstTimeEZ restored the vulkan-initialize-value branch November 18, 2024 04:27
@FirstTimeEZ FirstTimeEZ reopened this Nov 18, 2024
@FirstTimeEZ FirstTimeEZ reopened this Nov 18, 2024
@FirstTimeEZ FirstTimeEZ deleted the vulkan-initialize-value branch November 18, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FirstTimeEZ @0cc4m