vulkan: predicate max operation in soft_max shaders/soft_max #10437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It does fix the issue. Thank you! |
0cc4m
approved these changes
Nov 20, 2024
Collaborator
0cc4m
left a comment
0cc4m
left a comment
There was a problem hiding this comment.
The unit tests didn't catch this one. Thanks for the quick fix.
Collaborator
Author
|
Yeah, I guess this requires a value larger than the max being computed for an invalid column, and the random data in the unit tests just isn't likely to generate that. |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10434
Removing the break and putting if tests right around the loads was an optimization, but the max() operation also needed the if test.