Skip to content

Conversation

@slaren
Copy link
Member

@slaren slaren commented Nov 29, 2024

  • Removed links that no longer work or that do not reference llama.cpp
  • Removed the blurb in the few links that had it

Copy link
Collaborator

@JohannesGaessler JohannesGaessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I originally added the list my idea was to explicitly mark those projects that do not use permissive licenses since those are the cases where you can potentially get into legal trouble. But subsequently license declarations were added for permissive projects anyways wo maybe it would make sense to remove the sentence prior to the list and just list the license for each project?

@slaren
Copy link
Member Author

slaren commented Nov 29, 2024

Yes, I will try to add the missing licenses and remove the sentence.

@JohannesGaessler
Copy link
Collaborator

Looking at the list I'm noticing that the names for Github repositories are also inconsistent: for some it's <Github user>/<repository name> and for some it's just <repository name>. I don't have a preference but while we're at it I think it would make sense to use a consistent notation.

@slaren
Copy link
Member Author

slaren commented Nov 29, 2024

Most of these were added by the project authors themselves, so I think it is ok to leave it the way they prefer it.

@JohannesGaessler
Copy link
Collaborator

That's also fine I guess.

@ngxson
Copy link
Collaborator

ngxson commented Nov 29, 2024

Btw I'm also thinking about these ideas:

  • Maybe move supported models, binding, UI, etc into a page called showcase.md, leaving "Usage" on top of the main README
  • Maybe also remove downstream project that haven't been updated for a long time (i.e. check their last commit)

@slaren
Copy link
Member Author

slaren commented Nov 29, 2024

Agree, the lists are getting too big and they kind of detract from the more important information in the README. I will leave that for a different PR, though.

@JohannesGaessler
Copy link
Collaborator

The UI list in particular could be listed as one of the methods to use llama.cpp.

@slaren slaren merged commit a3a3048 into master Nov 29, 2024
2 checks passed
@slaren slaren deleted the sl/cleanup-links branch November 29, 2024 16:45
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Dec 20, 2024
* cleanup UI link list

* sort list alphabetically

* add missing licenses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants