Skip to content

Conversation

@wangqin0
Copy link
Contributor

@wangqin0 wangqin0 commented Dec 1, 2024

It is still possible for clip_model_load to throw exceptions that will cause undefined behavior when reaching the C caller.

Test:

  • GG_BUILD_CUDA=1 bash ./ci/run.sh ./tmp/results ./tmp/mnt returns 0 although no result output printed in console.

Copy link
Member

@slaren slaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the projector_type enum are incompatible with the coding style of this project. Please revert these changes and remove only the exception.

@wangqin0
Copy link
Contributor Author

Thanks for reviewing. I use enum class instead of enum because common, example and src have used enum class and it is more confined, type-safe, and part of C++11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants