server : Improve code snippets direction between RTL text #11221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
approved these changes
Jan 14, 2025
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns
to this
The prompt is:
سلام آیا میتوانی کدی به زبان سی بنویسی که دو عدد را به صورت گرفته و جمع کرده و در خروجی چاپ کند؟ ممنونم(basically asks to write a C code to take two numbers and print the sum) and the model is 'phi-4-q4.gguf' of https://huggingface.co/microsoft/phi-4-ggufIf you want the picture however, it's better to not apply dir="auto" to the whole message but to apply it to every individual paragraphs, like what is suggested on markdown-it/markdown-it#635 (comment) which refers to what I implemented in gitlab years ago https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/6296 and the solution for markdown-it is to add a plugin https://github.com/dobidi/markdown-it-bidi but I wasn't sure if adding a new dependency just for this sake is acceptable and this will cover the most cases which is intended for llama-server but surely can be considered for later.