fix makefile and cmake logic for AARCH64 #11246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
srigi
approved these changes
Jan 16, 2025
Member
|
|
Contributor
Author
|
Is this in addition to what's enabled with GGML_AVX2? Part of the motivation behind this is the build failing for clang versions prior to 18, specifically the ROCM compiler. These changes fall short of fixing it but everything I've found points to it being an issue with clang's handling of aarch64 and getting stuck in an infinite loop. |
Some ifndef slipped through in place of ifdefs and are throwing the compiler for a loop. Use ifdef to match inclusive filters in the Makefile.
Haus1
force-pushed
the
fix-makefile-logic
branch
from
071c087 to
b8005c8
Compare
Contributor
Author
|
Updated to include a few more for arm that somehow got missed and removed the changes to GGML_CPU_AARCH64. The indenting and formatting of the Makefile can be a bit confusing/inconsistent but that's beyond the scope here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ifndef slipped through in place of ifdefs and are throwing the compiler for a loop.
Use ifdef to match inclusive filters in the Makefile and have GGML_CPU_AARCH64 default to OFF. This prevents the compiler from becoming confused and optimizing for the wrong architecture.
#11204
#11082
#11083
#11079
#11071
#10933