Skip to content

Conversation

stevegrubb
Copy link
Contributor

Add missing underscore to a layer_norm_epsilon parameter.

Add missing underscore to a layer_norm_epsilon parameter.
@github-actions github-actions bot added the python python script changes label Jan 23, 2025
@ngxson
Copy link
Collaborator

ngxson commented Jan 23, 2025

@stevegrubb
Copy link
Contributor Author

OK. That seems familiar (I saw this about a year ago and was rechecking this). But then I see layer_norm_epsilon everywhere else in the file. Out of curiosity, why isn't this consistent? I'd like to leave a note explaining this if everything is correct. Thx.

@ngxson
Copy link
Collaborator

ngxson commented Jan 24, 2025

Can you point out the line with layer_norm_epsilon?

After changing, have you test it? We can't accept a PR without knowing it of work.

@stevegrubb
Copy link
Contributor Author

Yes, I have used an updated program to convert from a huggingface repo to a gguf file. I haven't observed any problems, but maybe the model didn't have this in it? Some examples where it has the extra underscore are lines: 246, 1021, 1362, etc. There are 18 occurrences. With 18 places where it is different, it is easy to conclude the one I changed is a typo and should be in sync with the others.

@ngxson
Copy link
Collaborator

ngxson commented Jan 28, 2025

I can't find any pass issue about this, so it's better not to assume that this is typo.

If it still works, better not to touch it.

@ngxson ngxson closed this Jan 28, 2025
@stevegrubb stevegrubb deleted the convert_hf branch January 28, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants