Skip to content

Conversation

@mofosyne
Copy link
Collaborator

@mofosyne mofosyne commented Feb 3, 2025

Issue Ticket: #11630

@mofosyne
Copy link
Collaborator Author

mofosyne commented Feb 3, 2025

Not as familiar with CMake, but looks like this change doesn't quite work.

@slaren
Copy link
Member

slaren commented Feb 3, 2025

The public directory still needs to be public. Some examples may depend on the llama targeting adding the src and common to the include directories, and will need to be adjusted. Some tests use headers from src because they need the lower level access to llama.cpp. That's ok, but they need to add the include directory themselves.

@mofosyne mofosyne closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants