swift : fix llama-vocab api usage #11645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Feb 4, 2025
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
Really appreciate the help! Thank you.
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
* swiftui : fix vocab api usage * batched.swift : fix vocab api usage
orca-zhang
pushed a commit
to orca-zhang/llama.cpp
that referenced
this pull request
Feb 26, 2025
* swiftui : fix vocab api usage * batched.swift : fix vocab api usage
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
* swiftui : fix vocab api usage * batched.swift : fix vocab api usage
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
* swiftui : fix vocab api usage * batched.swift : fix vocab api usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersede #11632.
Currently I managed to run llama-swiftui example by cmake build (from here), but Xcode can't archive the dylibs into app (build successful but crash at runtime), so I just move the dylibs into Frameworks/ manually.
Also, I can't build batched.swift successfully, so it not tested yet. I might also look at the current Swift package issues later.