common : change longest common subsequence to substring [no ci] #11657
Conversation
This commit updates the comments in the code to reflect that the function common_lcs() is actually computing the length of the longest common substring between two sequences (consecutive elements), not the longest common subsequence. The motivation for this change it to clarify the intent of the function.
|
Tbh, I'm not sure if some of your recent changes are even necessary. Totally appreciate contribution here and there, but what I absolutely don't want is to be too nitpicking. IMO the priority should spending time focus on fixing bugs and implementing new functions. If you want to continue doing small changes like this, please expect that I'll allocate less time to review them. Regarding this PR, I believe this is based on the famous Longest Common Subsequence leetcode problem, so I think it's totally ok to keep it that way in this context. |
|
The reason for opening this is that I was surprised when reading through server code and the comment in server.cpp and in
Note taken, and I'll be more careful about opening PRs moving forward, my intention was not to be a burden 👍
There is also Longest Common Substing and perhaps this is where the confusion lies. |
2 participants
This commit updates the comments in the code to reflect that the function
common_lcs()is actually computing the length of the longest common substring between two sequences (consecutive elements), not the longest common subsequence.The motivation for this change it to clarify the intent of the function.