Skip to content

common : change longest common subsequence to substring [no ci] #11657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

common : change longest common subsequence to substring [no ci] #11657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1652,7 +1652,7 @@ size_t common_lcs(const llama_tokens & a, const llama_tokens & b) {
size_t a_len = a.size();
size_t b_len = b.size();

// initialize the maximum length of the longest common subsequence (LCS)
// initialize the maximum length of the longest common substring (LCS)
size_t max_length = 0;

// use two rows instead of a 2D matrix to optimize space
Expand Down
2 changes: 1 addition & 1 deletion common/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ void common_batch_add(
// longest common prefix
size_t common_lcp(const llama_tokens & a, const llama_tokens & b);

// longet common subsequence
// longest common substring
size_t common_lcs(const llama_tokens & a, const llama_tokens & b);

//
Expand Down
4 changes: 2 additions & 2 deletions examples/server/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2008,10 +2008,10 @@ struct server_context {
continue;
}

// length of the Longest Common Subsequence between the current slot's prompt and the input prompt
// length of the Longest Common Substring between the current slot's prompt and the input prompt
int cur_lcs_len = common_lcs(slot.cache_tokens, task.prompt_tokens);

// fraction of the common subsequence length compared to the current slot's prompt length
// fraction of the common substring length compared to the current slot's prompt length
float cur_similarity = static_cast<float>(cur_lcs_len) / static_cast<int>(slot.cache_tokens.size());

// select the current slot if the criteria match
Expand Down