Skip to content

Conversation

@PopSoda2002
Copy link

Make sure to read the contributing guidelines before submitting a PR

I have tested the CI in my local computer bash ./ci/run.sh ./tmp/results ./tmp/mnt
All pass, no error.
image

What has been done

Change enum -> enum class, it's safer stackoverflow

@ggerganov
Copy link
Member

This change is not useful and I don't think it improves over the way we currently use enums in the codebase. In general, enum class has advantages, but they are not very relevant to our usecases.

@ggerganov ggerganov closed this Feb 10, 2025
@PopSoda2002
Copy link
Author

I think enum class is nothing disadvantages but advantages compared with pure enum. Sometimes pure enum will have bugs but enum class will never.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants