Skip to content

Conversation

@iehgit
Copy link

@iehgit iehgit commented Feb 10, 2025

It is not intended to write data to the file for others to read.

It is not intended to write data to the file for others to read.
@IMbackK
Copy link
Collaborator

IMbackK commented Feb 11, 2025

No, thats a terrible idea. MAP_PRIVATE requires the kernel to reserve space for the file in its overcommit total, as the kernel might need to find the ram/swap to store the entire file, if the process with the map decides to write to every page in the file.
This change would thus break llamacpp in cases where there is overcommit/memory pressure

@slaren slaren closed this Feb 17, 2025
@iehgit iehgit deleted the patch-2 branch February 17, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants