scripts: corrected encoding when getting chat template (#11866) #11907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MoonRide303 <[email protected]>
Contributor
Author
|
@ochafik This fixes problem with existing script (#11866 (comment)). I am also wondering if I should add this variant of mine #11866 (comment), which allows saving UTF-8 encoded templates (sys.stdout used in current script produces UTF-16 output - at least on Windows). |
orca-zhang
pushed a commit
to orca-zhang/llama.cpp
that referenced
this pull request
Feb 26, 2025
… (ggml-org#11907) Signed-off-by: MoonRide303 <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
… (ggml-org#11907) Signed-off-by: MoonRide303 <[email protected]>
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
… (ggml-org#11907) Signed-off-by: MoonRide303 <[email protected]>
mostlyuseful
pushed a commit
to mostlyuseful/llama.cpp
that referenced
this pull request
May 12, 2025
… (ggml-org#11907) Signed-off-by: MoonRide303 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON files must be UTF-8 encoded, see 8.1 in RFC 8259.