ggml-backend : make path_str compatible with C++20 #12269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
slaren
approved these changes
Mar 8, 2025
| 蕭澧邦 <[email protected]> | ||
| 谢乃闻 <[email protected]> | ||
| Нияз Гарифзянов <[email protected]> | ||
| Jason C.H <[email protected]> |
Member
There was a problem hiding this comment.
@ggerganov I am not sure what are the guidelines for modifying this file, I believe that until now it has been generated automatically from the git commits. Should this change be merged as is?
Member
There was a problem hiding this comment.
Either way is fine - the gen-authors.sh script will re-generate the file.
I'll run it after this gets in.
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12144 breaks the compatibility with C++20
In C++20,
fs::path::u8string()return type changed fromstd::string(C++17) tostd::u8string(C++20+). This PR modifies thepath_strfunction to use conditional compilation to detect__cpp_lib_char8_t(a standard feature flag introduced in C++20):std::u8stringtostd::stringstd::stringdirectly