Refactoring '-o' option #12278
Merged
Refactoring '-o' option #12278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in PR 'llama-tts : add -o option' (ggml-org#12042): * common_params : 'out_file' string is the only output file name parameter left in common_params. It's intended to be used in all example programs implementing an '-o' option. * cvector-generator, export-lora, imatrix : default output filenames moved from 'common_params' to the 'main()' of each example program.
ggerganov
approved these changes
Mar 10, 2025
Member
|
We can merge if the CI is green. |
ngxson
approved these changes
Mar 10, 2025
Collaborator
ngxson
left a comment
ngxson
left a comment
There was a problem hiding this comment.
I rerun the CI, seems like temporary error
Member
|
The CI error is related to #11227 (comment). Will be fixed separately. |
jpohhhh
pushed a commit
to Telosnex/llama.cpp
that referenced
this pull request
Mar 14, 2025
As discussed in PR 'llama-tts : add -o option' (ggml-org#12042): * common_params : 'out_file' string is the only output file name parameter left in common_params. It's intended to be used in all example programs implementing an '-o' option. * cvector-generator, export-lora, imatrix : default output filenames moved from 'common_params' to the 'main()' of each example program.
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Mar 19, 2025
As discussed in PR 'llama-tts : add -o option' (ggml-org#12042): * common_params : 'out_file' string is the only output file name parameter left in common_params. It's intended to be used in all example programs implementing an '-o' option. * cvector-generator, export-lora, imatrix : default output filenames moved from 'common_params' to the 'main()' of each example program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in PR 'llama-tts : add -o option' (#12042):
common_params : 'out_file' string is the only output file name parameter left in 'common_params'. It's intended to be used in all example programs implementing an '-o' option.
cvector-generator, export-lora, imatrix : default output filenames moved from 'common_params' to the 'main()' of each example program.