Skip to content

webui: Stop rerender on textarea input and end the devastating lag #12299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2025
Merged

webui: Stop rerender on textarea input and end the devastating lag #12299

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbf8cad
webui: Make textarea uncontrolled to eliminate devastating lag
woof-dog Mar 10, 2025
2eb91bf
Update index.html.gz
woof-dog Mar 10, 2025
c4ce55a
use signal-style implementation
ngxson Mar 11, 2025
c67e523
rm console log
ngxson Mar 11, 2025
cc4dcc9
no duplicated savedInitValue set
ngxson Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified examples/server/public/index.html.gz
View file
Open in desktop
Binary file not shown.
31 changes: 17 additions & 14 deletions examples/server/webui/src/components/ChatScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,15 @@ export default function ChatScreen() {
canvasData,
replaceMessageAndGenerate,
} = useAppContext();
const [inputMsg, setInputMsg] = useState(prefilledMsg.content());
const inputRef = useRef<HTMLTextAreaElement>(null);

const { extraContext, clearExtraContext } = useVSCodeContext(
inputRef,
setInputMsg
(msg) => {
if (inputRef?.current) {
inputRef.current.value = msg;
}
}
);
// TODO: improve this when we have "upload file" feature
const currExtra: Message['extra'] = extraContext ? [extraContext] : undefined;
Expand Down Expand Up @@ -135,9 +138,14 @@ export default function ChatScreen() {
};

const sendNewMessage = async () => {
if (inputMsg.trim().length === 0 || isGenerating(currConvId ?? '')) return;
const lastInpMsg = inputMsg;
setInputMsg('');
if (
!inputRef.current ||
inputRef.current.value.trim().length === 0 ||
isGenerating(currConvId ?? '')
)
return;
const inputValue = inputRef.current.value;
inputRef.current.value = '';
scrollToBottom(false);
setCurrNodeId(-1);
// get the last message node
Expand All @@ -146,13 +154,13 @@ export default function ChatScreen() {
!(await sendMessage(
currConvId,
lastMsgNodeId,
inputMsg,
inputValue,
currExtra,
onChunk
))
) {
// restore the input message if failed
setInputMsg(lastInpMsg);
inputRef.current.value = inputValue;
}
// OK
clearExtraContext();
Expand Down Expand Up @@ -259,8 +267,7 @@ export default function ChatScreen() {
className="textarea textarea-bordered w-full"
placeholder="Type a message (Shift+Enter to add a new line)"
ref={inputRef}
value={inputMsg}
onChange={(e) => setInputMsg(e.target.value)}
defaultValue={prefilledMsg.content()}
Copy link
Collaborator

@ngxson ngxson Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There could be a race condition between prefilledMsg.content() and prefilledMsg.clear() above

onKeyDown={(e) => {
if (e.nativeEvent.isComposing || e.keyCode === 229) return;
if (e.key === 'Enter' && e.shiftKey) return;
Expand All @@ -280,11 +287,7 @@ export default function ChatScreen() {
Stop
</button>
) : (
<button
className="btn btn-primary ml-2"
onClick={sendNewMessage}
disabled={inputMsg.trim().length === 0}
>
<button className="btn btn-primary ml-2" onClick={sendNewMessage}>
Send
</button>
)}
Expand Down