vulkan: fix bug in coopmat1 mul_mat_id #12316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
jeffbolznv
force-pushed
the
cm1_mul_mat_id
branch
from
6534e01 to
be17331
Compare
0cc4m
approved these changes
Mar 12, 2025
ishaangandhi
pushed a commit
to ishaangandhi/llama.cpp
that referenced
this pull request
Mar 12, 2025
* tests: run mul_mat_id with a larger N * vulkan: fix bug in coopmat1 mul_mat_id
jpohhhh
pushed a commit
to Telosnex/llama.cpp
that referenced
this pull request
Mar 14, 2025
* tests: run mul_mat_id with a larger N * vulkan: fix bug in coopmat1 mul_mat_id
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Mar 19, 2025
* tests: run mul_mat_id with a larger N * vulkan: fix bug in coopmat1 mul_mat_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across these failures while I was testing mul_mat_id with larger values of N, to verify other PRs.