Skip to content

Conversation

ngxson
Copy link
Collaborator

@ngxson ngxson commented Mar 18, 2025

Important

At the time of writing this, HF model is missing chat template, let's wait until this PR is merged!

This PR allows converting text model from Mistral Small to GGUF

For vision, I don't know yet how it work. Will work it that later.

And congrats to @mistralai team for the release

@ngxson ngxson requested a review from ggerganov March 18, 2025 14:37
@github-actions github-actions bot added the python python script changes label Mar 18, 2025
@bartowski1182
Copy link
Contributor

chat template is merged, LGTM!

@ngxson
Copy link
Collaborator Author

ngxson commented Mar 18, 2025

@bartowski1182 Waiting for your gguf quant to test hehe

@bartowski1182
Copy link
Contributor

merging locally to check :)

@bartowski1182
Copy link
Contributor

quant worked: https://huggingface.co/lmstudio-community/Mistral-Small-3.1-24B-Instruct-2503-GGUF

verifying locally that it runs without issue (though imatrix is working which is usually a good sign)

@bartowski1182
Copy link
Contributor

looks like it worked! but something went wrong with chat template so gonna have to redo that part :')

@bartowski1182
Copy link
Contributor

oh whoops, i was looking at the wrong chat template PR merge!

@bartowski1182
Copy link
Contributor

Okay, merged your changes and the chat template locally (minus the "today's date" portion which doesn't play nice usually), and uploaded the quants:

https://huggingface.co/lmstudio-community/Mistral-Small-3.1-24B-Instruct-2503-GGUF

They run in LM Studio so i think we're safe to say it works !

@ngxson
Copy link
Collaborator Author

ngxson commented Mar 18, 2025

Nice, thanks for testing. Now I'm waiting for approval to merge this.

@Kaszebe
Copy link

Kaszebe commented Mar 18, 2025

Slowpoke here...image recognition won't work in LM Studio until ggerganov merges the changes?

@bartowski1182
Copy link
Contributor

@Kaszebe it won't work until @ngxson works some (powerful) magic and figures it out, it's non-trivial to add.

Thankfully text version of this seems straightforward so we get to play around with it until vision is figured out later :) (assume days minimum, possibly weeks depending on difficulty)

@ngxson ngxson merged commit 29fff30 into ggml-org:master Mar 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python script changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants