Skip to content

Conversation

@yeahdongcn
Copy link
Collaborator

Make sure to read the contributing guidelines before submitting a PR

/home/xiaodongye/ws/ggml/llama.cpp/ggml/src/ggml-cuda/template-instances/../common.cuh:246:39: warning: '&&' within '||' [-Wlogical-op-parentheses]
    return GGML_CUDA_CC_IS_NVIDIA(cc) && ggml_cuda_highest_compiled_arch(cc) >= GGML_CUDA_CC_VOLTA ||
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
/home/xiaodongye/ws/ggml/llama.cpp/ggml/src/ggml-cuda/template-instances/../common.cuh:246:39: note: place parentheses around the '&&' expression to silence this warning
    return GGML_CUDA_CC_IS_NVIDIA(cc) && ggml_cuda_highest_compiled_arch(cc) >= GGML_CUDA_CC_VOLTA ||
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/xiaodongye/ws/ggml/llama.cpp/ggml/src/ggml-cuda/template-instances/../common.cuh:253:39: warning: '&&' within '||' [-Wlogical-op-parentheses]
    return GGML_CUDA_CC_IS_NVIDIA(cc) && cc >= GGML_CUDA_CC_VOLTA ||
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
/home/xiaodongye/ws/ggml/llama.cpp/ggml/src/ggml-cuda/template-instances/../common.cuh:253:39: note: place parentheses around the '&&' expression to silence this warning
    return GGML_CUDA_CC_IS_NVIDIA(cc) && cc >= GGML_CUDA_CC_VOLTA ||
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~

I also made some minor changes to align the code style in checking cc.

Testing Done

  • musa cmake build

Signed-off-by: Xiaodong Ye <[email protected]>
@github-actions github-actions bot added Nvidia GPU Issues specific to Nvidia GPUs ggml changes relating to the ggml tensor library for machine learning labels Mar 24, 2025
@JohannesGaessler JohannesGaessler merged commit 7ea7503 into ggml-org:master Mar 24, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants