- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.5k
 
llama-server : implement universal assisted decoding #12635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 19 commits
      Commits
    
    
            Show all changes
          
          
            27 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      6f96269
              
                llama-server : implement universal assisted decoding
              
              
                g2mt 6f74c9c
              
                Merge branch 'master' into master
              
              
                g2mt e667645
              
                Merge remote-tracking branch 'fork/master' into universal-decoding
              
              
                g2mt ff9e062
              
                Erase prompt tail for kv-cache
              
              
                g2mt 39ca594
              
                set vocab_dft_compatible in common_speculative
              
              
                g2mt eb424dd
              
                rename ctx_main to ctx_tgt
              
              
                g2mt 2550f11
              
                move vocab_dft_compatible to spec struct
              
              
                g2mt 3c35c9d
              
                clear mem_dft, remove mem
              
              
                g2mt 12751c9
              
                detokenize id_last for incompatible models
              
              
                g2mt 8419931
              
                update comment
              
              
                g2mt b9fdf20
              
                add --spec-replace flag
              
              
                g2mt 160769d
              
                accept special tokens when translating between draft/main models
              
              
                g2mt ebaa82e
              
                Merge remote-tracking branch 'upstream/master'
              
              
                g2mt d1f32ab
              
                Escape spec-replace
              
              
                g2mt 3afb556
              
                Merge branch 'ggml-org:master' into master
              
              
                g2mt d23892e
              
                clamp draft result to size to params.n_draft
              
              
                g2mt c382c28
              
                Merge branch 'ggml-org:master' into master
              
              
                g2mt e14bafb
              
                Merge branch 'ggml-org:master' into master
              
              
                g2mt f8cee4e
              
                Merge branch 'ggml-org:master' into master
              
              
                g2mt 2cc9e2e
              
                fix comment
              
              
                g2mt 829b762
              
                clean up code
              
              
                g2mt b045eac
              
                restore old example
              
              
                g2mt 79d2be4
              
                log common_speculative_are_compatible in speculative example
              
              
                g2mt 6acc681
              
                fix
              
              
                g2mt 50908f2
              
                Update common/speculative.cpp
              
              
                g2mt e866f23
              
                Update common/speculative.cpp
              
              
                g2mt 24cede7
              
                Update common/speculative.cpp
              
              
                g2mt File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which cases do we need to use replacements?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this in case translation improves speculation accuracy. It's specifically built for instruct tags like
<|im_start|>etc.