gguf-split now respects dry-run option #12681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is bug fixing for this issue. |
|
I'll test this later this week. In the meantime, could you fix the trailing space issue? https://github.com/ggml-org/llama.cpp/actions/runs/14183518821/job/39778406801?pr=12681 |
|
sure, I will take a look soon.
thanks.
my journey is oceans of stars...
…________________________________
From: Xuan-Son Nguyen ***@***.***>
Sent: Wednesday, April 2, 2025 4:58 AM
To: ggml-org/llama.cpp ***@***.***>
Cc: nick huang ***@***.***>; Author ***@***.***>
Subject: Re: [ggml-org/llama.cpp] gguf-split now respects dry-run option (PR #12681)
I'll test this later this week. In the meantime, could you fix the trailing space issue? https://github.com/ggml-org/llama.cpp/actions/runs/14183518821/job/39778406801?pr=12681
—
Reply to this email directly, view it on GitHub<#12681 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA6LMIZXZGBFSREUOH42TF32XL4XXAVCNFSM6AAAAAB2FO7GW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZQGY3DSMJXGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
[ngxson]ngxson left a comment (ggml-org/llama.cpp#12681)<#12681 (comment)>
I'll test this later this week. In the meantime, could you fix the trailing space issue? https://github.com/ggml-org/llama.cpp/actions/runs/14183518821/job/39778406801?pr=12681
—
Reply to this email directly, view it on GitHub<#12681 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA6LMIZXZGBFSREUOH42TF32XL4XXAVCNFSM6AAAAAB2FO7GW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZQGY3DSMJXGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
ngxson
approved these changes
Apr 4, 2025
timwu
pushed a commit
to timwu/llama.cpp
that referenced
this pull request
May 5, 2025
* gguf-split now respects dry-run option * removing trailing space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to read the contributing guidelines before submitting a PR
examples/gguf-split now respects "dry-run" option for merge operation just like split operation.