Skip to content

Sync minja patch to support inclusionAI/Ling-lite template and update tests#12699

Merged
CISC merged 1 commit intoggml-org:masterfrom
makllama:xd/fix_template_ling
Apr 3, 2025
Merged

Sync minja patch to support inclusionAI/Ling-lite template and update tests#12699
CISC merged 1 commit intoggml-org:masterfrom
makllama:xd/fix_template_ling

Conversation

@yeahdongcn
Copy link
Copy Markdown
Collaborator

@yeahdongcn yeahdongcn commented Apr 2, 2025

Make sure to read the contributing guidelines before submitting a PR

google/minja#58
Credit goes to @ochafik.

Testing Done

  • ./build/bin/test-chat-template
  • ./build/bin/llama-cli -m ./llama-cli -m /home/xiaodongye/.cache/huggingface/hub/models--mradermacher--Ling-lite-GGUF/snapshots/a338e70b6371205bbf2396154171e25524ca3c71/Ling-lite.Q4_K_M.gguf -ngl 999

@github-actions github-actions bot added the testing Everything test related label Apr 2, 2025
… tests

Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
@yeahdongcn yeahdongcn force-pushed the xd/fix_template_ling branch from 7afc072 to 191f68b Compare April 2, 2025 02:45
Copy link
Copy Markdown
Member

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ochafik regularly syncs minja, other than that LGTM.

@CISC CISC merged commit 5f696e8 into ggml-org:master Apr 3, 2025
48 checks passed
@ochafik ochafik mentioned this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants