CANN: Refactor to reduce duplicate code #12731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
hipudding
commented
Apr 3, 2025
hipudding
commented
Apr 3, 2025
hipudding
commented
Apr 3, 2025
noemotiovon
reviewed
Apr 3, 2025
hipudding
commented
Apr 7, 2025
noemotiovon
approved these changes
Apr 7, 2025
|
The source of openEuler OS is not stable these days. I have tested this PR in my local environment. |
slaren
approved these changes
Apr 7, 2025
colout
pushed a commit
to colout/llama.cpp
that referenced
this pull request
Apr 29, 2025
* CANN: Refactor to reduce duplicate code * CANN: fix review comment
timwu
pushed a commit
to timwu/llama.cpp
that referenced
this pull request
May 5, 2025
* CANN: Refactor to reduce duplicate code * CANN: fix review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to read the contributing guidelines before submitting a PR
Refactor to reduce duplicate code