Fixes #12823 #12830
Merged
Fixes #12823 #12830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
slaren
approved these changes
Apr 8, 2025
ggml/src/ggml-cpu/simd-mappings.h
Outdated
| vec_extract_fp32_from_shorth(vec_xl(0, p - GGML_F16_EPR)) : \ | ||
| vec_extract_fp32_from_shortl(vec_xl(0, p)) | ||
| #define GGML_ENDIAN_BYTE(i) ((unsigned char *)&(uint16_t){1})[i] | ||
| static inline unsigned char ggml_endian_byte(int i){ |
There was a problem hiding this comment.
Suggested change
| static inline unsigned char ggml_endian_byte(int i){ | |
| static inline unsigned char ggml_endian_byte(int i) { |
There was a problem hiding this comment.
Updated files according to reviewed suggestions. Thank you!!
mehendarkarprajwal
force-pushed
the
gh_12823
branch
from
fa63fea to
9653d4c
Compare
colout
pushed a commit
to colout/llama.cpp
that referenced
this pull request
Apr 21, 2025
* Including limits file on AIX * Fixes ggml-org#12823
timwu
pushed a commit
to timwu/llama.cpp
that referenced
this pull request
May 5, 2025
* Including limits file on AIX * Fixes ggml-org#12823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent redesign of ggml-cpu we see that it was failing to compile on POWER arch on both ppcle64 and AIX. The changes in this PR is for fixing the compilation issue.