ggml-impl.h: Fix build issues on AArch64 with CUDA version 12 #12872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ggml-org#12732: * Remove incorrect inclusion of "arm_neon.h" for CUDA versions ≥ 12
zhengjun-xing
force-pushed
the
fix-build-aarch64-cuda12
branch
from
725be9c to
d85170b
Compare
github-actions
bot
added
the
ggml
|
Should be fixed with cb79c2e |
|
Thanks for merging this PR! Just curious—why was the author name changed? Is that typical in open source workflows? |
|
Thanks for merging this PR! Just curious—why was the author name changed?
Is that typical in open source workflows?
Zhengjun
Georgi Gerganov ***@***.***> 于2025年4月11日周五 05:19写道：
… Should be fixed with cb79c2e
<cb79c2e>
—
Reply to this email directly, view it on GitHub
<#12872 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZ7KV7YX4X4WDNUNAIWTN7T2Y3N4LAVCNFSM6AAAAAB23H5H5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJVGE4DSOJZGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*ggerganov* left a comment (ggml-org/llama.cpp#12872)
<#12872 (comment)>
Should be fixed with cb79c2e
<cb79c2e>
—
Reply to this email directly, view it on GitHub
<#12872 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZ7KV7YX4X4WDNUNAIWTN7T2Y3N4LAVCNFSM6AAAAAB23H5H5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJVGE4DSOJZGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Oops, I initially thought the PR was merged, but it looks like it was actually closed without being merged. |
The same fix was proposed in parallel so we ended up merging the other PR: The final result should be the same. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12732:
Make sure to read the contributing guidelines before submitting a PR