Skip to content

Conversation

@qnixsynapse
Copy link
Collaborator

@qnixsynapse qnixsynapse commented Apr 11, 2025

Added ROPE vision kernel needed in ViTs including some image projectors of VLMs.

test-backend-ops is passing with this change.

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Apr 11, 2025
Copy link
Collaborator

@NeoZhangJianyu NeoZhangJianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good job!

Thank you!

@Rbiessy Rbiessy merged commit 5106764 into master Apr 15, 2025
51 checks passed
@qnixsynapse qnixsynapse deleted the rope_vision branch April 15, 2025 13:37
colout pushed a commit to colout/llama.cpp that referenced this pull request Apr 21, 2025
* SYCL: Add ROPE vision kernel

* Add comment about rope mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants